Issue 332973002: Remove [PerWorldBindings] from not performance-sensitive methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332973002: Remove [PerWorldBindings] from not performance-sensitive methods (Closed)

Created:
6 years, 6 months ago by haraken

Modified:
6 years, 6 months ago

Reviewers:
dcarney, jochen (gone - plz use gerrit)

CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, watchdog-blink-watchlist_google.com, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove [PerWorldBindings] from not performance-sensitive methods This CL removes binary size by 4 KB (Linux Release). I don't see any regression with this CL in Dromaeo. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176097

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -9 lines)			Patch
M	Source/core/dom/Document.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Element.idl	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/Node.idl	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/core/dom/Text.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/frame/Window.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/332973002/20001

6 years, 6 months ago (2014-06-13 06:23:05 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 6 months ago (2014-06-13 07:24:19 UTC) #5

Message was sent while issue was closed.

Change committed as 176097

Expand Messages | Collapse Messages