Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 332933002: Qualify the generated includes in core (partial) (Closed)

Created:
6 years, 6 months ago by c.shu
Modified:
6 years, 6 months ago
CC:
blink-reviews, chromiumbugtracker_adobe.com, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, groby+blinkspell_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Qualify the generated includes in core (partial) This CL takes care the dom, editing, events subdirs under core. BUG=381876 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176068

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -112 lines) Patch
M Source/core/dom/ContextFeatures.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMException.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/DocumentInit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentOrderedMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentStyleSheetCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/EmptyNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/LiveNodeListBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeRenderingTraversal.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Position.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ProcessingInstruction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/QualifiedName.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M Source/core/dom/RenderTreeBuilder.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/ScriptLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ShadowTreeStyleSheetCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyleEngine.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/StyleSheetCandidate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/VisitedLinkState.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/XMLDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/custom/CustomElementRegistrationContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementRegistry.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/InsertionPoint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyBlockElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/BreakBlockquoteCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/CompositeEditCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/FormatBlockCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/IndentOutdentCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertLineBreakCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/editing/RemoveCSSPropertyCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/RemoveFormatCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/ReplaceNodeWithSpanCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/SpellChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SplitElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TextIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TypingCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/markup.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/events/EventPath.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/EventTarget.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/events/ThreadLocalEventNames.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
c.shu
6 years, 6 months ago (2014-06-12 22:20:40 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-12 23:29:40 UTC) #2
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-12 23:48:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/332933002/1
6 years, 6 months ago (2014-06-12 23:49:02 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 00:56:11 UTC) #5
Message was sent while issue was closed. 
Change committed as 176068

Powered by Google App Engine
This is Rietveld 408576698