[sync] Add backup time in synced device info so that server can flag device

chrome/browser/sync/glue/synced_device_tracker_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/guid.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "chrome/browser/sync/glue/device_info.h"
 #include "chrome/browser/sync/glue/synced_device_tracker.h"
 #include "sync/internal_api/public/base/model_type.h"
 #include "sync/internal_api/public/test/test_user_share.h"
 #include "sync/protocol/sync.pb.h"
 #include "sync/syncable/directory.h"
 #include "sync/test/test_transaction_observer.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace browser_sync {
 
-namespace {
-
-void ConvertDeviceInfoSpecifics(
-    const DeviceInfo& device_info,
-    sync_pb::DeviceInfoSpecifics* specifics) {
-  specifics->set_cache_guid(device_info.guid());
-  specifics->set_client_name(device_info.client_name());
-  specifics->set_chrome_version(device_info.chrome_version());
-  specifics->set_sync_user_agent(device_info.sync_user_agent());
-  specifics->set_device_type(device_info.device_type());
-}
-
-}  // namespace
-
 class SyncedDeviceTrackerTest : public ::testing::Test {
  protected:
   SyncedDeviceTrackerTest() : transaction_count_baseline_(0) { }
   virtual ~SyncedDeviceTrackerTest() { }
 
   virtual void SetUp() {
     test_user_share_.SetUp();
     syncer::TestUserShare::CreateRoot(syncer::DEVICE_INFO, user_share());
 
     synced_device_tracker_.reset(
@@ skipping 15 matching lines @@
   syncer::UserShare* user_share() {
     return test_user_share_.user_share();
   }
 
   // Expose the private method to our tests.
   void WriteLocalDeviceInfo(const DeviceInfo& info) {
     synced_device_tracker_->WriteLocalDeviceInfo(info);
   }
 
   void WriteDeviceInfo(const DeviceInfo& device_info) {
-    sync_pb::DeviceInfoSpecifics specifics;
-    ConvertDeviceInfoSpecifics(device_info, &specifics);
-    synced_device_tracker_->WriteDeviceInfo(specifics, device_info.guid());
+    synced_device_tracker_->WriteDeviceInfo(device_info, device_info.guid());
   }
 
   void ResetObservedChangesCounter() {
     transaction_count_baseline_ = GetTotalTransactionsCount();
   }
 
   int GetObservedChangesCounter() {
     return GetTotalTransactionsCount() - transaction_count_baseline_;
   }
 
@@ skipping 116 matching lines @@
   WriteDeviceInfo(device_info2);
 
   ScopedVector<DeviceInfo> device_info;
   synced_device_tracker_->GetAllSyncedDeviceInfo(&device_info);
 
   EXPECT_EQ(device_info.size(), 2U);
   EXPECT_TRUE(device_info[0]->Equals(device_info1));
   EXPECT_TRUE(device_info[1]->Equals(device_info2));
 }
 
+TEST_F(SyncedDeviceTrackerTest, DeviceBackupTime) {
+  DeviceInfo device_info(
+      user_share()->directory->cache_guid(),
+      "John’s Device", "XYZ v1", "XYZ SyncAgent v1",
+      sync_pb::SyncEnums_DeviceType_TYPE_LINUX);
+  const base::Time test_backup_time =
+      base::Time::UnixEpoch() + base::TimeDelta::FromDays(10000);
+
+  WriteLocalDeviceInfo(device_info);
+  synced_device_tracker_->UpdateLocalDeviceBackupTime(test_backup_time);
+
+  // Verify read of device info and backup time.
+  EXPECT_EQ(test_backup_time,
+            synced_device_tracker_->GetLocalDeviceBackupTime());
+  scoped_ptr<DeviceInfo> device_info_out(
+      synced_device_tracker_->ReadLocalDeviceInfo());
+  ASSERT_TRUE(device_info_out);
+  EXPECT_TRUE(device_info.Equals(*device_info_out.get()));
+
+  // Verify backup time is not lost after updating device info.
+  DeviceInfo device_info2(
+      user_share()->directory->cache_guid(),
+      "def Device", "XYZ v2", "XYZ SyncAgent v2",
+      sync_pb::SyncEnums_DeviceType_TYPE_LINUX);
+  WriteLocalDeviceInfo(device_info2);
+  EXPECT_EQ(test_backup_time,
+            synced_device_tracker_->GetLocalDeviceBackupTime());
+}
+
 }  // namespace
 
 }  // namespace browser_sync