[sync] Add backup time in synced device info so that server can flag device

chrome/browser/sync/profile_sync_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
 
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 751 matching lines @@
 
   void SetBackupStartDelayForTest(base::TimeDelta delay);
 
   BackendMode backend_mode() const {
     return backend_mode_;
   }
 
   void SetClearingBrowseringDataForTesting(
       base::Callback<void(Profile*, base::Time, base::Time)> c);
 
+  base::Time GetDeviceBackupTimeForTesting() const;
+
  protected:
   // Helper to configure the priority data types.
   void ConfigurePriorityDataTypes();
 
   // Helper to install and configure a data type manager.
   void ConfigureDataTypeManager();
 
   // Shuts down the backend sync components.
   // |option| indicates if syncing is being disabled or not, and whether
   // to claim ownership of sync thread from backend.
@@ skipping 155 matching lines @@
 
   // True if a syncing backend exists.
   bool HasSyncingBackend() const;
 
   // Update first sync time stored in preferences
   void UpdateFirstSyncTimePref();
 
   // Clear browsing data since first sync during rollback.
   void ClearBrowsingDataSinceFirstSync();
 
+  // Post background task to check sync backup DB state if needed.
+  void CheckSyncBackupIfNeeded();
+
+  // Callback to receive backup DB check result.
+  void CheckSyncBackupCallback(base::Time backup_time);
+
  // Factory used to create various dependent objects.
   scoped_ptr<ProfileSyncComponentsFactory> factory_;
 
   // The profile whose data we are synchronizing.
   Profile* profile_;
 
   // The class that handles getting, setting, and persisting sync
   // preferences.
   sync_driver::SyncPrefs sync_prefs_;
 
@@ skipping 146 matching lines @@
 
   // Mode of current backend.
   BackendMode backend_mode_;
 
   // When browser starts, delay sync backup/rollback backend start for this
   // time.
   base::TimeDelta backup_start_delay_;
 
   base::Callback<void(Profile*, base::Time, base::Time)> clear_browsing_data_;
 
+  // Last time when pre-sync data was saved. NULL means backup data state is
+  // unknown. If time value is null, backup data doesn't exist.
+  scoped_ptr<base::Time> last_backup_time_;

[Nicolas Zea, 2014/06/13 22:36:41]

Does this need to be in a scoped ptr? Couldn't you just check for
base::Time::is_null()?

[haitaol1, 2014/06/13 23:28:25]

Using scoped_ptr makes it 3-state, NULL pointer means unknown, null time means
no backup.

On 2014/06/13 22:36:41, Nicolas Zea wrote:

+
   DISALLOW_COPY_AND_ASSIGN(ProfileSyncService);
 };
 
 bool ShouldShowActionOnUI(
     const syncer::SyncProtocolError& error);
 
 
 #endif  // CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_