Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 3329024: [Isolates] Make MarkCompactCollector::IterateLiveObject to treat callback as a method of the class. (Closed)

Created:
10 years, 3 months ago by Dmitry Titov
Modified:
9 years, 7 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev, yurys
Visibility:
Public.

Description

[Isolates] Make MarkCompactCollector::IterateLiveObject to invoke its callback as a member of MarkCompactCollector, eliminating the need for those callbacks to be static. This, in turn, makes them able to use MarkCompactCollector::heap_ variable instead of pulling the Heap pointer via Isolate::Current(). Committed: http://code.google.com/p/v8/source/detail?r=5444

Patch Set 1 #

Total comments: 1

Patch Set 2 : updated per review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -96 lines) Patch
M src/mark-compact.h View 1 4 chunks +14 lines, -11 lines 0 comments Download
M src/mark-compact.cc View 18 chunks +82 lines, -85 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Titov
I'm getting a small but measurable improvement on this (~1.5% locally on string-add)
10 years, 3 months ago (2010-09-10 22:20:38 UTC) #1
Vitaly Repeshko
LGTM http://codereview.chromium.org/3329024/diff/1/3 File src/mark-compact.h (right): http://codereview.chromium.org/3329024/diff/1/3#newcode365 src/mark-compact.h:365: typedef int (MarkCompactCollector::*LiveObjectCallback)(HeapObject* obj); Typedefs are supposed to ...
10 years, 3 months ago (2010-09-10 22:27:18 UTC) #2
Dmitry Titov
10 years, 3 months ago (2010-09-10 22:32:13 UTC) #3
Updated, landed. Thanks!

Powered by Google App Engine
This is Rietveld 408576698