Issue 332863003: Remove AccessControl from AccessorPairs, as it's an invalid usecase of AllCan*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332863003: Remove AccessControl from AccessorPairs, as it's an invalid usecase of AllCan* (Closed)

Created:
6 years, 6 months ago by Toon Verwaest

Modified:
6 years, 6 months ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Remove AccessControl from AccessorPairs, as it's an invalid usecase of AllCan* BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21918

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -137 lines)			Patch
M	src/api.cc	View	4 chunks	+6 lines, -4 lines	0 comments	Download
M	src/apinatives.js	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/factory.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/objects.h	View	4 chunks	+4 lines, -18 lines	0 comments	Download
M	src/objects.cc	View	10 chunks	+10 lines, -21 lines	0 comments	Download
M	src/objects-debug.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/objects-inl.h	View	2 chunks	+0 lines, -23 lines	0 comments	Download
M	src/objects-printer.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	4 chunks	+4 lines, -14 lines	0 comments	Download
M	test/cctest/test-api.cc	View	5 chunks	+5 lines, -44 lines	0 comments	Download
M	test/mjsunit/runtime-gen/setaccessorproperty.js	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/generate-runtime-tests.py	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Toon Verwaest

6 years, 6 months ago (2014-06-23 09:02:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21918 (presubmit successful).