generate_stubs: Allow // comments as well as the existing #.

generate_stubs: Allow // comments as well as the existing #.

BUG=none
TEST=generate_stubs_unittest.py
R=ajwong@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276925

[Robert Sesek, 2014-06-12 20:59:06]

Changed ALL the things.

[awong, 2014-06-12 21:09:44]

LGTM

CCing Dale so he knows what's up.

[DaleCurtis, 2014-06-12 21:13:57]

The CL title says it allows both, but the code seems to now only allow //, which
is going to break ffmpeg:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/ffmpeg...

You'll need to fix FFmpeg and include the DEPS roll with this before landing.

[awong, 2014-06-12 21:15:49]

LGTM for patchset #1

On 2014/06/12 21:13:57, DaleCurtis wrote:
> The CL title says it allows both, but the code seems to now only allow //,
which
> is going to break ffmpeg:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/ffmpeg...
> 
> You'll need to fix FFmpeg and include the DEPS roll with this before landing.

Too much effort.  Let's just go back to patchset #1

[Robert Sesek, 2014-06-12 21:19:13]

On 2014/06/12 21:15:49, awong wrote:
> LGTM for patchset #1
> 
> On 2014/06/12 21:13:57, DaleCurtis wrote:
> > The CL title says it allows both, but the code seems to now only allow //,
> which
> > is going to break ffmpeg:
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/ffmpeg...
> > 
> > You'll need to fix FFmpeg and include the DEPS roll with this before
landing.
> 
> Too much effort.  Let's just go back to patchset #1

Done in patch set 3.

Sorry for the confusion re: title. I update the description because that's what
gets committed, but changing the title changes the email thread subject, which
is I think more confusing sometimes.

[DaleCurtis, 2014-06-12 21:55:28]

lgtm

[Robert Sesek, 2014-06-12 21:58:14]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2014-06-12 21:59:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rsesek@chromium.org/332823003/60001

[commit-bot: I haz the power, 2014-06-13 04:41:22]

Change committed as 276925