Issue 332713003: Fix FirstNetworkByType, and some minor debugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332713003: Fix FirstNetworkByType, and some minor debugging (Closed)

Created:
6 years, 6 months ago by stevenjb

Modified:
6 years, 6 months ago

Reviewers:
pneubeck (no reviews)

CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix FirstNetworkByType, and some minor debugging The change to combine NetworkState and FavoriteState broke FirstNetworkByType for VPN since it doesn't appear with the "visible" networks. We don't use that method a lot, so the easy fix is to remove the early exit and continue instead of break. BUG=375955 TBR=pneubeck@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276851

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -1 line)			Patch
M	chrome/browser/resources/chromeos/network_ui/network_ui.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/network_ui/network_ui.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/network/network_state_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/network/network_util.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

stevenjb

Committed patchset #1 manually as r276851 (presubmit successful).

6 years, 6 months ago (2014-06-12 23:46:21 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages