Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 332683004: IDL parser: fix rebuilding of (stale) cached parser tables (Closed)

Created:
6 years, 6 months ago by Jens Widell
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL parser: fix rebuilding of (stale) cached parser tables The yacc parser's tables are cached to improve build performance, and are rebuilt by running blink_idl_parser.py directly, which simply initializes the IDL parser and expects PLY (yacc.py) to write the cached tables as a side-effect. However, if the file containing the cached tables exists, then PLY will instead try to load the stale cache. If that succeeds, it will disable the rewriting, since there's no point in writing to the cache what was just read from it. Fix by always deleting the cache file whenever blink_idl_parser.py is executed directly, before initializing the parser. This way, PLY will not use cached tables, and will instead write the cache file. BUG=387631 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176745

Patch Set 1 #

Total comments: 1

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M Source/bindings/scripts/blink_idl_parser.py View 1 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Jens Widell
Please review. I believe this fixes the weirdness discussed in https://codereview.chromium.org/329163002/.
6 years, 6 months ago (2014-06-23 10:35:17 UTC) #1
haraken
LGTM, but Nils wants to confirm.
6 years, 6 months ago (2014-06-23 10:47:18 UTC) #2
Nils Barth (inactive)
LGTM, with one comment request. Great sleuthing! PLY internals are pretty subtle; thanks for figuring ...
6 years, 6 months ago (2014-06-23 11:05:14 UTC) #3
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 6 months ago (2014-06-23 11:20:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/332683004/20001
6 years, 6 months ago (2014-06-23 11:20:35 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 12:25:11 UTC) #6
Message was sent while issue was closed.
Change committed as 176745

Powered by Google App Engine
This is Rietveld 408576698