Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 332683003: roll gyp 1927:1944 (Closed)

Created:
6 years, 6 months ago by Nico
Modified:
6 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews, yukawa, mtklein_C, bungeman-chromium, Shezan Baig (Bloomberg), Mark Mentovai, sky
Project:
chromium
Visibility:
Public.

Description

roll gyp 1927:1944 1928: use all processors instead of hard-coded 8. 1929: Fix msvs-ninja clean build command / target. 1930: ninja: Add option for link concurrency. 1931: Add unittest for 'AR' in 'make_global_settings' 1932: Override the user's language settings during tests 1933: ninja win: Remove old comment, check cc/cxx are always overridden 1934: Use context manager to manage OS environment in tests 1935: Teach Ninja generator about 'AR' in 'make_global_settings' 1936: First crack at adding a GYP_GENERATOR for determining various things 1937: Add unittest for 'LD' in 'make_global_settings' 1938: Remove unused parameters from test code. 1939: Revise unittest for 'LD' in 'make_global_settings' 1940: Revise unittest for 'AR' in 'make_global_settings' 1941: ninja: Read 'LD'/'LD.host' from 'make_global_settings_ld'. 1942: ninja: Read 'AR.host' from 'make_global_settings'. 1943: [gyp][Android] Implement TestGypAndroid.run_built_executable. 1944: ninja: Pass .so files outside of --start-group/--end-group. BUG=362075, skia:2439, gyp:434 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278051

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
6 years, 6 months ago (2014-06-18 00:08:52 UTC) #1
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 6 months ago (2014-06-18 00:09:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/332683003/1
6 years, 6 months ago (2014-06-18 00:09:59 UTC) #3
scottmg
go/gypbot is busted again :( but fingers lgtm'd.
6 years, 6 months ago (2014-06-18 00:20:06 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 13:09:32 UTC) #5
Message was sent while issue was closed.
Change committed as 278051

Powered by Google App Engine
This is Rietveld 408576698