Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 332663005: Add schemas to Skia repo (Closed)

Created:
6 years, 6 months ago by kelvinly
Modified:
6 years, 6 months ago
Reviewers:
jcgregorio, benchen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -0 lines) Patch
A bench/microbench.json View 1 chunk +122 lines, -0 lines 0 comments Download
A bench/skpbench.json View 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kelvinly
Looks like they'll be accessible through https://raw.githubusercontent.com/google/skia , unless there's another mirror you guys would ...
6 years, 6 months ago (2014-06-20 21:39:08 UTC) #1
benchen
The file names are not very descriptive. Maybe microbench_json_data_schema.json A better source might be googlesource.com ...
6 years, 6 months ago (2014-06-20 21:49:00 UTC) #2
kelvinly
On 2014/06/20 21:49:00, benchen wrote: > The file names are not very descriptive. Maybe microbench_json_data_schema.json ...
6 years, 6 months ago (2014-06-20 22:21:50 UTC) #3
kelvinly
On 2014/06/20 22:21:50, kelvinly wrote: > On 2014/06/20 21:49:00, benchen wrote: > > The file ...
6 years, 6 months ago (2014-06-20 22:26:49 UTC) #4
benchen
On 2014/06/20 22:26:49, kelvinly wrote: > On 2014/06/20 22:21:50, kelvinly wrote: > > On 2014/06/20 ...
6 years, 6 months ago (2014-06-20 22:30:32 UTC) #5
kelvinly
On 2014/06/20 22:30:32, benchen wrote: > On 2014/06/20 22:26:49, kelvinly wrote: > > On 2014/06/20 ...
6 years, 6 months ago (2014-06-23 14:18:01 UTC) #6
jcgregorio
On 2014/06/23 14:18:01, kelvinly wrote: > On 2014/06/20 22:30:32, benchen wrote: > > On 2014/06/20 ...
6 years, 6 months ago (2014-06-23 15:24:39 UTC) #7
kelvinly
The CQ bit was checked by kelvinly@google.com
6 years, 6 months ago (2014-06-23 15:31:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kelvinly@google.com/332663005/1
6 years, 6 months ago (2014-06-23 15:33:05 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 16:02:42 UTC) #10
Message was sent while issue was closed.
Change committed as b0203e5b223b3c2381c209898358bdc3e2131ec9

Powered by Google App Engine
This is Rietveld 408576698