Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 332663004: For-of calls [Symbol.iterator]() on RHS to get iterator (Closed)

Created:
5 years, 1 month ago by wingo
Modified:
5 years, 1 month ago
Reviewers:
rossberg
CC:
v8-dev, PaweĊ‚ Hajdan Jr., arv (Not doing code reviews)
Visibility:
Public.

Description

For-of calls [Symbol.iterator]() on RHS to get iterator R=rossberg@chromium.org BUG=http://code.google.com/p/v8/issues/detail?id=2735 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21820

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -112 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M src/array-iterator.js View 3 chunks +14 lines, -0 lines 0 comments Download
M src/ast.h View 3 chunks +9 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/contexts.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/generator.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +4 lines, -13 lines 0 comments Download
M src/parser.cc View 2 chunks +32 lines, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +5 lines, -12 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M test/mjsunit/harmony/iteration-semantics.js View 10 chunks +45 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wingo
PTAL. The change to the AST is kinda nasty but seemed to be the smallest ...
5 years, 1 month ago (2014-06-12 08:52:37 UTC) #1
rossberg
LGTM. You might want to add a simple test checking that generators actually have a ...
5 years, 1 month ago (2014-06-12 12:36:40 UTC) #2
wingo
On 2014/06/12 12:36:40, rossberg wrote: > LGTM. You might want to add a simple test ...
5 years, 1 month ago (2014-06-12 14:32:41 UTC) #3
wingo
5 years, 1 month ago (2014-06-12 17:32:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21820 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698