Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 332633006: Include error status code in console message for non-CORS response. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Include error status code in console message for non-CORS response. While CORS is concerned with the access control headers that come back in the response and not its status code, an error response (status code >= 400) containing no CORS headers is most likely an indication of the server not being configured correctly. To potentially help the user/developer more quickly diagnose that as the problem, include the status code in the console message that's emitted for the failed CORS resource sharing check. R= BUG=269192 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177116

Patch Set 1 #

Patch Set 2 : Update test expectation #

Messages

Total messages: 5 (0 generated)
sof
Please take a look. This is sometimes a source of CORS debugging confusion for users/developers; ...
6 years, 5 months ago (2014-06-27 12:09:10 UTC) #1
abarth-chromium
lgtm
6 years, 5 months ago (2014-06-27 15:38:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/332633006/20001
6 years, 5 months ago (2014-06-27 15:39:26 UTC) #3
tyoshino (SeeGerritForStatus)
lgtm
6 years, 5 months ago (2014-06-27 16:03:56 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 16:54:10 UTC) #5
Message was sent while issue was closed.
Change committed as 177116

Powered by Google App Engine
This is Rietveld 408576698