content/browser/devtools/devtools_power_handler.cc - Issue 332623003: [DevTools] [PowerProfiler] Fix for browser crash with active timeline recording for capturing power.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_power_handler.cc

Issue 332623003: [DevTools] [PowerProfiler] Fix for browser crash with active timeline recording for capturing power. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/devtools/devtools_power_handler.cc

diff --git a/content/browser/devtools/devtools_power_handler.cc b/content/browser/devtools/devtools_power_handler.cc

index 27fdf294c6fe88cb35343980cedd6e6f56beb3f3..43772b47607e2dddd54bd4cab003f3f8f5716e3d 100644

--- a/content/browser/devtools/devtools_power_handler.cc

+++ b/content/browser/devtools/devtools_power_handler.cc

@@ -24,6 +24,7 @@ DevToolsPowerHandler::DevToolsPowerHandler() {

}

DevToolsPowerHandler::~DevToolsPowerHandler() {

+ PowerProfilerService::GetInstance()->RemoveObserver(this);

qsr 2014/06/13 15:45:59 LGTM, but you might want to use a base/scoped_obse

}

void DevToolsPowerHandler::OnPowerEvent(const PowerEventVector& events) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »