Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: content/browser/devtools/devtools_power_handler.cc

Issue 332623003: [DevTools] [PowerProfiler] Fix for browser crash with active timeline recording for capturing power. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/power_profiler/power_profiler_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/devtools/devtools_power_handler.h" 5 #include "content/browser/devtools/devtools_power_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "content/browser/devtools/devtools_protocol_constants.h" 9 #include "content/browser/devtools/devtools_protocol_constants.h"
10 #include "content/browser/power_profiler/power_profiler_service.h" 10 #include "content/browser/power_profiler/power_profiler_service.h"
11 11
12 namespace content { 12 namespace content {
13 13
14 DevToolsPowerHandler::DevToolsPowerHandler() { 14 DevToolsPowerHandler::DevToolsPowerHandler() {
15 RegisterCommandHandler(devtools::Power::start::kName, 15 RegisterCommandHandler(devtools::Power::start::kName,
16 base::Bind(&DevToolsPowerHandler::OnStart, 16 base::Bind(&DevToolsPowerHandler::OnStart,
17 base::Unretained(this))); 17 base::Unretained(this)));
18 RegisterCommandHandler(devtools::Power::end::kName, 18 RegisterCommandHandler(devtools::Power::end::kName,
19 base::Bind(&DevToolsPowerHandler::OnEnd, 19 base::Bind(&DevToolsPowerHandler::OnEnd,
20 base::Unretained(this))); 20 base::Unretained(this)));
21 RegisterCommandHandler(devtools::Power::canProfilePower::kName, 21 RegisterCommandHandler(devtools::Power::canProfilePower::kName,
22 base::Bind(&DevToolsPowerHandler::OnCanProfilePower, 22 base::Bind(&DevToolsPowerHandler::OnCanProfilePower,
23 base::Unretained(this))); 23 base::Unretained(this)));
24 } 24 }
25 25
26 DevToolsPowerHandler::~DevToolsPowerHandler() { 26 DevToolsPowerHandler::~DevToolsPowerHandler() {
27 PowerProfilerService::GetInstance()->RemoveObserver(this);
27 } 28 }
28 29
29 void DevToolsPowerHandler::OnPowerEvent(const PowerEventVector& events) { 30 void DevToolsPowerHandler::OnPowerEvent(const PowerEventVector& events) {
30 base::DictionaryValue* params = new base::DictionaryValue(); 31 base::DictionaryValue* params = new base::DictionaryValue();
31 base::ListValue* event_list = new base::ListValue(); 32 base::ListValue* event_list = new base::ListValue();
32 33
33 std::vector<PowerEvent>::const_iterator iter; 34 std::vector<PowerEvent>::const_iterator iter;
34 for (iter = events.begin(); iter != events.end(); ++iter) { 35 for (iter = events.begin(); iter != events.end(); ++iter) {
35 base::DictionaryValue* event_body = new base::DictionaryValue(); 36 base::DictionaryValue* event_body = new base::DictionaryValue();
36 37
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 DevToolsPowerHandler::OnCanProfilePower( 74 DevToolsPowerHandler::OnCanProfilePower(
74 scoped_refptr<DevToolsProtocol::Command> command) { 75 scoped_refptr<DevToolsProtocol::Command> command) {
75 base::DictionaryValue* result = new base::DictionaryValue(); 76 base::DictionaryValue* result = new base::DictionaryValue();
76 result->SetBoolean(devtools::kResult, 77 result->SetBoolean(devtools::kResult,
77 PowerProfilerService::GetInstance()->IsAvailable()); 78 PowerProfilerService::GetInstance()->IsAvailable());
78 79
79 return command->SuccessResponse(result); 80 return command->SuccessResponse(result);
80 } 81 }
81 82
82 } // namespace content 83 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/browser/power_profiler/power_profiler_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698