Issue 332613004: Use IDL argument default values in modules/indexeddb/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332613004: Use IDL argument default values in modules/indexeddb/ (Closed)

Created:
6 years, 6 months ago by Jens Widell

Modified:
6 years, 6 months ago

Reviewers:
dgrogan, jsbell

CC:
blink-reviews, dgrogan, jsbell+idb_chromium.org, alecflett, ericu+idb_chromium.org, cmumford

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Use IDL argument default values in modules/indexeddb/ Replace bogus 'null' default values for DOMString arguments with the actual default values from the spec, and remove the handling of null strings in the C++ implementation. Also replace [Default=Undefined] on some boolean arguments with the default value 'false' from the spec, which has the same effect. BUG=258153 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176930

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -13 lines)			Patch
M	Source/modules/indexeddb/IDBCursor.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/indexeddb/IDBDatabase.idl	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/modules/indexeddb/IDBIndex.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/modules/indexeddb/IDBKeyRange.idl	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/modules/indexeddb/IDBObjectStore.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/modules/indexeddb/IDBTransaction.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/332613004/1

6 years, 6 months ago (2014-06-25 16:11:25 UTC) #4

Message was sent while issue was closed.

Change committed as 176930

Expand Messages | Collapse Messages