Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 332593002: Do not mirror views bubbles anchored to minimized widgets. (Closed)

Created:
6 years, 6 months ago by msw
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, msw+watch_chromium.org, alicet1, tfarina, yao, Finnur
Visibility:
Public.

Description

Do not mirror views bubbles anchored to minimized widgets. Bubbles should not use the anchor rect of minimized windows. BUG=372713 TEST=Minimizing and restoring Chrome with a session restore bubble should leave the bubble anchored as it was. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/views/bubble/bubble_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
msw
Hey Scott, please take a look; thanks!
6 years, 6 months ago (2014-06-11 22:53:34 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-12 15:34:26 UTC) #2
msw
The CQ bit was checked by msw@chromium.org
6 years, 6 months ago (2014-06-12 16:05:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/332593002/1
6 years, 6 months ago (2014-06-12 16:09:01 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 23:19:09 UTC) #5
Message was sent while issue was closed.
Change committed as 276845

Powered by Google App Engine
This is Rietveld 408576698