Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 332573006: terminatePausedTest (Closed)

Created:
6 years, 6 months ago by michaeln
Modified:
6 years, 5 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Renable a serviceworker browser test to StartPaused_ThenStop. BUG=371671 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280297

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
michaeln
ptal, here's the test for https://codereview.chromium.org/337223004/
6 years, 6 months ago (2014-06-25 00:32:20 UTC) #1
falken
lgtm, just remember to replace the "DON'T COMMIT" note in the CL description with a ...
6 years, 6 months ago (2014-06-25 00:51:41 UTC) #2
michaeln
The CQ bit was checked by michaeln@chromium.org
6 years, 6 months ago (2014-06-26 20:49:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/332573006/40001
6 years, 6 months ago (2014-06-26 20:50:00 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-27 02:34:23 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 10:45:46 UTC) #6
Message was sent while issue was closed.
Change committed as 280297

Powered by Google App Engine
This is Rietveld 408576698