Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 332573003: Add missing null check in PageSerializer::serializeCSSStyleSheet() (Closed)

Created:
6 years, 6 months ago by Inactive
Modified:
6 years, 6 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Add missing null check in PageSerializer::serializeCSSStyleSheet() Add missing null check in PageSerializer::serializeCSSStyleSheet() for importRule->styleSheet(). CSSImportRule::styleSheet() can return null but the function it is being passed to expects a non-null pointer. Also update PageSerializer::serializeCSSStyleSheet() to take its CSSStyleSheet argument by reference, instead of pointer to make it obvious to the caller that passing null is not OK. R=morrita@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M Source/core/page/PageSerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PageSerializer.cpp View 3 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
This is the avoid a crash we've seen when saving http://na.leagueoflegends.com/. Unfortunately, I haven't been ...
6 years, 6 months ago (2014-06-11 23:45:00 UTC) #1
Inactive
6 years, 6 months ago (2014-06-13 12:29:17 UTC) #2
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-13 17:35:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/332573003/1
6 years, 6 months ago (2014-06-13 17:36:33 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 18:41:42 UTC) #5
Message was sent while issue was closed.
Change committed as 176123

Powered by Google App Engine
This is Rietveld 408576698