Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 332563003: Remove RenderViewImpl::OnNavigate (Closed)

Created:
6 years, 6 months ago by nasko
Modified:
6 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, siam.trading
Visibility:
Public.

Description

Remove RenderViewImpl::OnNavigate BUG=304341 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276711

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nasko
Hey John, Can you review this CL for me? I'm trying to clean up some ...
6 years, 6 months ago (2014-06-11 21:21:50 UTC) #1
jam
lgtm
6 years, 6 months ago (2014-06-11 22:27:54 UTC) #2
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 6 months ago (2014-06-12 07:45:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/332563003/1
6 years, 6 months ago (2014-06-12 07:49:20 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 16:46:31 UTC) #5
Message was sent while issue was closed.
Change committed as 276711

Powered by Google App Engine
This is Rietveld 408576698