Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 332553002: Tracing out IndexedDB transaction ID's for chrome://tracing. (Closed)

Created:
6 years, 6 months ago by cmumford
Modified:
6 years, 6 months ago
Reviewers:
jsbell
CC:
chromium-reviews, jam, alecflett, ericu+idb_chromium.org, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Tracing out IndexedDB transaction ID's for chrome://tracing. BUG=365189 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276883

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added parens around macro parameters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -34 lines) Patch
M content/browser/indexed_db/indexed_db_database.cc View 29 chunks +48 lines, -31 lines 0 comments Download
M content/browser/indexed_db/indexed_db_tracing.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_transaction.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
cmumford
Should be helpful to track down some of the spinning CPU bugs.
6 years, 6 months ago (2014-06-11 20:43:33 UTC) #1
jsbell
lgtm https://codereview.chromium.org/332553002/diff/1/content/browser/indexed_db/indexed_db_tracing.h File content/browser/indexed_db/indexed_db_tracing.h (right): https://codereview.chromium.org/332553002/diff/1/content/browser/indexed_db/indexed_db_tracing.h#newcode11 content/browser/indexed_db/indexed_db_tracing.h:11: TRACE_EVENT1("IndexedDB", (a), arg1_name, arg1_val); arg1_name and arg1_val should ...
6 years, 6 months ago (2014-06-11 21:49:57 UTC) #2
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 6 months ago (2014-06-11 22:29:17 UTC) #3
cmumford
The CQ bit was unchecked by cmumford@chromium.org
6 years, 6 months ago (2014-06-11 22:29:40 UTC) #4
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 6 months ago (2014-06-11 22:39:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/332553002/20001
6 years, 6 months ago (2014-06-11 22:40:49 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 23:58:10 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 00:07:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/21965)
6 years, 6 months ago (2014-06-12 00:07:20 UTC) #9
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 6 months ago (2014-06-12 16:24:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/332553002/20001
6 years, 6 months ago (2014-06-12 16:27:45 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 02:17:21 UTC) #12
Message was sent while issue was closed.
Change committed as 276883

Powered by Google App Engine
This is Rietveld 408576698