Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 332523008: Revert of Add tests for session cache and false start behavior. (Closed)

Created:
6 years, 6 months ago by please use gerrit instead
Modified:
6 years, 6 months ago
Reviewers:
agl, Ryan Sleevi, davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Revert of Add tests for session cache and false start behavior. (https://codereview.chromium.org/301283004/) Reason for revert: This patch may have broken http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/24391, but we're not confident. The failure is in libjingle_unittests, e.g. ChromeAsyncSocketTest.DoubleSSLConnect. Sorry for the inconvenience. Original issue's description: > Add tests for session cache and false start behavior. > > False start should not disable the session cache, but if we never process the > server Finished message, the session cannot be resumed. > > BUG=none > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276815 TBR=davidben@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -163 lines) Patch
M net/socket/ssl_client_socket_unittest.cc View 6 chunks +30 lines, -143 lines 0 comments Download
M third_party/tlslite/README.chromium View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/tlslite/patches/ignore_write_failure.patch View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/tlslite/tlslite/tlsrecordlayer.py View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
please use gerrit instead
Created Revert of Add tests for session cache and false start behavior.
6 years, 6 months ago (2014-06-12 23:47:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/332523008/1
6 years, 6 months ago (2014-06-12 23:52:43 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 23:52:44 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-12 23:52:46 UTC) #4
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 6 months ago (2014-06-12 23:57:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/332523008/1
6 years, 6 months ago (2014-06-12 23:58:18 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 00:01:22 UTC) #7
Message was sent while issue was closed.
Change committed as 276857

Powered by Google App Engine
This is Rietveld 408576698