Issue 332523003: Attempt to fix a NULL deref in sandbox::LaunchdInterceptionServer::HandleLookUp().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332523003: Attempt to fix a NULL deref in sandbox::LaunchdInterceptionServer::HandleLookUp(). (Closed)

Created:
6 years, 6 months ago by Robert Sesek

Modified:
6 years, 6 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Attempt to fix a NULL deref in sandbox::LaunchdInterceptionServer::HandleLookUp(). BUG=383279 R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276654

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -14 lines)			Patch
	M	sandbox/mac/launchd_interception_server.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	sandbox/mac/launchd_interception_server.cc	View		4 chunks	+12 lines, -11 lines	0 comments	Download

Total messages: 4 (0 generated)

Robert Sesek

It's not possible to write a deterministic test for this, since this I think relies ...

6 years, 6 months ago (2014-06-11 21:02:52 UTC) #1

Mark Mentovai

LGTM. I can see how the bug might have been caused by this race, and ...

6 years, 6 months ago (2014-06-11 21:18:17 UTC) #2

Robert Sesek

On 2014/06/11 21:18:17, Mark Mentovai wrote: > LGTM. I can see how the bug might ...

6 years, 6 months ago (2014-06-11 21:22:33 UTC) #3

Robert Sesek

6 years, 6 months ago (2014-06-12 13:11:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r276654 (presubmit successful).