Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: WebCore/html/HTMLAnchorElement.cpp

Issue 3325025: Merge 67261 - Make middle clicks not fire DOM onclick events.... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/517/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « WebCore/ChangeLog ('k') | WebCore/html/HTMLInputElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann <hausmann@kde.org> 4 * (C) 2000 Simon Hausmann <hausmann@kde.org>
5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
6 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 6 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 496 matching lines...) Expand 10 before | Expand all | Expand 10 after
507 return event->type() == eventNames().keydownEvent && event->isKeyboardEvent( ) && static_cast<KeyboardEvent*>(event)->keyIdentifier() == "Enter"; 507 return event->type() == eventNames().keydownEvent && event->isKeyboardEvent( ) && static_cast<KeyboardEvent*>(event)->keyIdentifier() == "Enter";
508 } 508 }
509 509
510 bool isMiddleMouseButtonEvent(Event* event) 510 bool isMiddleMouseButtonEvent(Event* event)
511 { 511 {
512 return event->isMouseEvent() && static_cast<MouseEvent*>(event)->button() == MiddleButton; 512 return event->isMouseEvent() && static_cast<MouseEvent*>(event)->button() == MiddleButton;
513 } 513 }
514 514
515 bool isLinkClick(Event* event) 515 bool isLinkClick(Event* event)
516 { 516 {
517 return event->type() == eventNames().clickEvent && (!event->isMouseEvent() | | static_cast<MouseEvent*>(event)->button() != RightButton); 517 return event->type() == eventNames().clickEvent || (event->type() == eventNa mes().mouseupEvent && isMiddleMouseButtonEvent(event));
518 } 518 }
519 519
520 void handleLinkClick(Event* event, Document* document, const String& url, const String& target, bool hideReferrer) 520 void handleLinkClick(Event* event, Document* document, const String& url, const String& target, bool hideReferrer)
521 { 521 {
522 event->setDefaultHandled(); 522 event->setDefaultHandled();
523 523
524 Frame* frame = document->frame(); 524 Frame* frame = document->frame();
525 if (!frame) 525 if (!frame)
526 return; 526 return;
527 frame->loader()->urlSelected(document->completeURL(url), target, event, fals e, false, true, hideReferrer ? NoReferrer : SendReferrer); 527 frame->loader()->urlSelected(document->completeURL(url), target, event, fals e, false, true, hideReferrer ? NoReferrer : SendReferrer);
528 } 528 }
529 529
530 } 530 }
OLDNEW
« no previous file with comments | « WebCore/ChangeLog ('k') | WebCore/html/HTMLInputElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698