Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: WebCore/ChangeLog

Side-by-side diff isn't available for this file because of its large size.
Issue 3325025: Merge 67261 - Make middle clicks not fire DOM onclick events.... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/517/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « LayoutTests/fast/events/script-tests/mouse-click-events.js ('k') | WebCore/html/HTMLAnchorElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 67262)
+++ WebCore/ChangeLog (working copy)
@@ -1,7 +1,28 @@
-2010-09-109 Peter Kasting <pkasting@google.com>
+2010-09-10 Peter Kasting <pkasting@google.com>
Reviewed by Darin Adler.
+ Make middle clicks not fire DOM onclick events.
+ https://bugs.webkit.org/show_bug.cgi?id=22382
+
+ * html/HTMLAnchorElement.cpp: Explicitly include middle-clicks in the
+ computation of what constitutes a link click, since they're no longer
+ implicitly included.
+ (WebCore::isLinkClick):
+ * html/HTMLInputElement.cpp: Removed unneeded checks that click events
+ are coming from the left mouse button, since they all are now.
+ (WebCore::HTMLInputElement::preDispatchEventHandler):
+ (WebCore::HTMLInputElement::postDispatchEventHandler):
+ (WebCore::HTMLInputElement::defaultEventHandler):
+ * page/EventHandler.cpp: Changed logic to send a click event only for
+ the left button.
+ (WebCore::EventHandler::handleMouseDoubleClickEvent):
+ (WebCore::EventHandler::handleMouseReleaseEvent):
+
+2010-09-10 Peter Kasting <pkasting@google.com>
+
+ Reviewed by Darin Adler.
+
Cleanup and simplification in advance of making middle clicks not send a
click event.
https://bugs.webkit.org/show_bug.cgi?id=22382
« no previous file with comments | « LayoutTests/fast/events/script-tests/mouse-click-events.js ('k') | WebCore/html/HTMLAnchorElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698