Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 332493002: DevTools: Support async call stacks for scripted animation events (like scroll). (Closed)

Created:
6 years, 6 months ago by aandrey
Modified:
6 years, 6 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, blink-reviews-dom_chromium.org, shans, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, rjwright, Steve Block, rwlbuis, caseq+blink_chromium.org, aandrey+blink_chromium.org, arv+blink, pfeldman+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, dstockwell, Timothy Loh, devtools-reviews_chromium.org, Eric Willigers, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, blink-reviews-animation_chromium.org, vsevik+blink_chromium.org, Mike Lawther (Google), Inactive, sergeyv+blink_chromium.org, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

DevTools: Support async call stacks for scripted animation events (like scroll). BUG=272416 R=yurys@chromium.org, pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176221

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -17 lines) Patch
A LayoutTests/inspector/sources/debugger/async-callstack-scripted-scroll.html View 1 1 chunk +56 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/async-callstack-scripted-scroll-expected.txt View 1 1 chunk +19 lines, -0 lines 0 comments Download
M Source/core/dom/ScriptedAnimationController.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/events/EventTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.h View 3 chunks +5 lines, -2 lines 2 comments Download
M Source/core/inspector/AsyncCallStackTracker.cpp View 1 3 chunks +30 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +14 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
aandrey
6 years, 6 months ago (2014-06-11 18:13:15 UTC) #1
aandrey
ping?
6 years, 6 months ago (2014-06-16 09:10:02 UTC) #2
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 6 months ago (2014-06-16 11:48:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/332493002/20001
6 years, 6 months ago (2014-06-16 11:49:13 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 11:49:13 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-16 11:49:15 UTC) #6
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 6 months ago (2014-06-16 11:51:37 UTC) #7
yurys
The CQ bit was unchecked by yurys@chromium.org
6 years, 6 months ago (2014-06-16 11:51:55 UTC) #8
yurys
lgtm https://codereview.chromium.org/332493002/diff/20001/Source/core/inspector/AsyncCallStackTracker.h File Source/core/inspector/AsyncCallStackTracker.h (right): https://codereview.chromium.org/332493002/diff/20001/Source/core/inspector/AsyncCallStackTracker.h#newcode91 Source/core/inspector/AsyncCallStackTracker.h:91: void didEnqueueEvent(EventTarget*, Event*, const ScriptValue& callFrames); Maybe call ...
6 years, 6 months ago (2014-06-16 11:52:15 UTC) #9
aandrey
https://codereview.chromium.org/332493002/diff/20001/Source/core/inspector/AsyncCallStackTracker.h File Source/core/inspector/AsyncCallStackTracker.h (right): https://codereview.chromium.org/332493002/diff/20001/Source/core/inspector/AsyncCallStackTracker.h#newcode91 Source/core/inspector/AsyncCallStackTracker.h:91: void didEnqueueEvent(EventTarget*, Event*, const ScriptValue& callFrames); On 2014/06/16 11:52:15, ...
6 years, 6 months ago (2014-06-16 12:18:38 UTC) #10
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 6 months ago (2014-06-16 12:18:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/332493002/20001
6 years, 6 months ago (2014-06-16 12:19:38 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 13:52:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12102)
6 years, 6 months ago (2014-06-16 13:52:15 UTC) #14
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 6 months ago (2014-06-16 14:16:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/332493002/20001
6 years, 6 months ago (2014-06-16 14:16:58 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 16:44:34 UTC) #17
Message was sent while issue was closed. 
Change committed as 176221

Powered by Google App Engine
This is Rietveld 408576698