Pepper: Remove LOAD_MODULE SRPC call in SFI mode.

components/nacl/common/nacl_types.h

Index: components/nacl/common/nacl_types.h
diff --git a/components/nacl/common/nacl_types.h b/components/nacl/common/nacl_types.h
index e2c77938957f74fc031c67167c472efc527b7195..a0fc509c66c525da2a3dddd84e76eda6327b9051 100644
--- a/components/nacl/common/nacl_types.h
+++ b/components/nacl/common/nacl_types.h
@@ -44,6 +44,8 @@ struct NaClStartParams {
   ~NaClStartParams();
 
   IPC::PlatformFileForTransit nexe_file;
+  uint64_t nexe_token_lo;
+  uint64_t nexe_token_hi;
 
   std::vector<FileDescriptor> handles;
   FileDescriptor debug_stub_server_bound_socket;
@@ -60,6 +62,7 @@ struct NaClStartParams {
   bool enable_ipc_proxy;
   bool uses_irt;
   bool enable_dyncode_syscalls;
+
   // NOTE: Any new fields added here must also be added to the IPC
   // serialization in nacl_messages.h and (for POD fields) the constructor
   // in nacl_types.cc.
@@ -73,6 +76,8 @@ struct NaClLaunchParams {
   NaClLaunchParams();
   NaClLaunchParams(const std::string& manifest_url,
                    const IPC::PlatformFileForTransit& nexe_file,
+                   uint64_t nexe_token_lo,
+                   uint64_t nexe_token_hi,
                    int render_view_id,
                    uint32 permission_bits,
                    bool uses_irt,
@@ -80,11 +85,13 @@ struct NaClLaunchParams {
                    bool enable_dyncode_syscalls,
                    bool enable_exception_handling,
                    bool enable_crash_throttling);
-  NaClLaunchParams(const NaClLaunchParams& l);
   ~NaClLaunchParams();
 
   std::string manifest_url;
   IPC::PlatformFileForTransit nexe_file;

[hidehiko, 2014/07/01 05:39:01]

Probably, it would be better to note that, on Windows, this HANDLE is valid in
the renderer's context, (because it seems not a common manner in Chrome?)

Or, IMHO, it may be ok to expose the BrokerGetFileHandleForProcess(), because
its underlying API BrokerDuplicateHandle is already in the public and
BrokerGetFileHandleForProcess looks its simpler wrapper. WDYT?

[teravest, 2014/07/01 17:48:34]

I've added a comment here as you suggested. I thought about trying to use
BrokerGetFileHandleForProcess to duplicate the handle in the renderer, but I
think it's simpler to only duplicate the handle once, and not bother involving
the broker.

+  uint64_t nexe_token_lo;
+  uint64_t nexe_token_hi;
+
   int render_view_id;
   uint32 permission_bits;
   bool uses_irt;