Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 332463002: Maximize only normal/popup window (Closed)

Created:
6 years, 6 months ago by oshima
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Maximize only normal/popup window Used to maximize menu as well. Toggle home card when ctrl-l is pressed. BUG=380438 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276582

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M athena/home/home_card_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M athena/wm/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M athena/wm/window_manager_impl.cc View 2 chunks +4 lines, -1 line 1 comment Download

Messages

Total messages: 12 (0 generated)
oshima
6 years, 6 months ago (2014-06-11 17:24:33 UTC) #1
Mr4D (OOO till 08-26)
lgtm https://codereview.chromium.org/332463002/diff/1/athena/wm/window_manager_impl.cc File athena/wm/window_manager_impl.cc (right): https://codereview.chromium.org/332463002/diff/1/athena/wm/window_manager_impl.cc#newcode129 athena/wm/window_manager_impl.cc:129: (*iter)->type() == ui::wm::WINDOW_TYPE_POPUP) There were some discussions about ...
6 years, 6 months ago (2014-06-11 18:09:25 UTC) #2
oshima
On 2014/06/11 18:09:25, Mr4D wrote: > lgtm > > https://codereview.chromium.org/332463002/diff/1/athena/wm/window_manager_impl.cc > File athena/wm/window_manager_impl.cc (right): > ...
6 years, 6 months ago (2014-06-11 18:14:33 UTC) #3
oshima
tbr'ing ben for the following new deps ui/wm in athena/wm/DEPS
6 years, 6 months ago (2014-06-11 18:15:33 UTC) #4
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 6 months ago (2014-06-11 18:15:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/332463002/1
6 years, 6 months ago (2014-06-11 18:16:42 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:38:34 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:41:07 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19675)
6 years, 6 months ago (2014-06-11 21:41:08 UTC) #9
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 6 months ago (2014-06-12 04:22:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/332463002/1
6 years, 6 months ago (2014-06-12 04:23:33 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 08:22:56 UTC) #12
Message was sent while issue was closed.
Change committed as 276582

Powered by Google App Engine
This is Rietveld 408576698