Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 332453002: remove GetDeviceConfig/SetDeviceConfig (Closed)

Created:
6 years, 6 months ago by reed1
Modified:
6 years, 6 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

remove GetDeviceConfig/SetDeviceConfig BUG=skia: Committed: https://skia.googlesource.com/skia/+/2f785a24eba5b59da30f5ffa0c53cc731e4c3078

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -42 lines) Patch
M include/core/SkImageDecoder.h View 1 2 chunks +0 lines, -17 lines 0 comments Download
M src/images/SkImageDecoder.cpp View 1 3 chunks +1 line, -19 lines 0 comments Download
M src/ports/SkImageDecoder_empty.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
reed1
will wait for removing in android before landing.
6 years, 6 months ago (2014-06-11 17:06:46 UTC) #1
scroggo
On 2014/06/11 17:06:46, reed1 wrote: > will wait for removing in android before landing. LGTM
6 years, 6 months ago (2014-06-11 17:08:00 UTC) #2
scroggo
On 2014/06/11 17:08:00, scroggo wrote: > On 2014/06/11 17:06:46, reed1 wrote: > > will wait ...
6 years, 6 months ago (2014-06-11 23:16:41 UTC) #3
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 6 months ago (2014-06-11 23:16:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/332453002/1
6 years, 6 months ago (2014-06-11 23:17:09 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 23:17:10 UTC) #6
commit-bot: I haz the power
Failed to apply patch for src/images/SkImageDecoder.cpp: While running git apply --index -p1; error: patch failed: ...
6 years, 6 months ago (2014-06-11 23:17:11 UTC) #7
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-12 15:57:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/332453002/20001
6 years, 6 months ago (2014-06-12 15:58:03 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 16:21:36 UTC) #10
Message was sent while issue was closed.
Change committed as 2f785a24eba5b59da30f5ffa0c53cc731e4c3078

Powered by Google App Engine
This is Rietveld 408576698