Add support for computed property names in object literals

src/typing.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/typing.h"
 
 #include "src/frames.h"
 #include "src/frames-inl.h"
 #include "src/parser.h"  // for CompileTimeValue; TODO(rossberg): should move
 #include "src/scopes.h"
@@ skipping 382 matching lines @@
   NarrowType(expr, Bounds(Type::RegExp(zone())));
 }
 
 
 void AstTyper::VisitObjectLiteral(ObjectLiteral* expr) {
   ZoneList<ObjectLiteral::Property*>* properties = expr->properties();
   for (int i = 0; i < properties->length(); ++i) {
     ObjectLiteral::Property* prop = properties->at(i);
 
     // Collect type feedback.
-    if ((prop->kind() == ObjectLiteral::Property::MATERIALIZED_LITERAL &&
-        !CompileTimeValue::IsCompileTimeValue(prop->value())) ||
-        prop->kind() == ObjectLiteral::Property::COMPUTED) {
-      if (prop->key()->value()->IsInternalizedString() && prop->emit_store()) {
-        prop->RecordTypeFeedback(oracle());
-      }
+    switch (prop->kind()) {
+      case ObjectLiteral::Property::MATERIALIZED_LITERAL:
+        if (CompileTimeValue::IsCompileTimeValue(prop->value())) break;
+        // Fall through.
+      case ObjectLiteral::Property::COMPUTED:
+        if (prop->key()->AsLiteral()->value()->IsInternalizedString() &&
+            prop->emit_store()) {
+          prop->RecordTypeFeedback(oracle());
+        }
+        break;
+
+      case ObjectLiteral::Property::COMPUTED_NAME:
+        RECURSE(Visit(prop->key()));
+        break;
+
+      case ObjectLiteral::Property::CONSTANT:
+      case ObjectLiteral::Property::PROTOTYPE:
+      case ObjectLiteral::Property::GETTER:
+      case ObjectLiteral::Property::SETTER:
+        break;
     }
 
     RECURSE(Visit(prop->value()));
   }
 
   NarrowType(expr, Bounds(Type::Object(zone())));
 }
 
 
 void AstTyper::VisitArrayLiteral(ArrayLiteral* expr) {
@@ skipping 354 matching lines @@
 void AstTyper::VisitModuleUrl(ModuleUrl* module) {
 }
 
 
 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) {
   RECURSE(Visit(stmt->body()));
 }
 
 
 } }  // namespace v8::internal