Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4258)

Unified Diff: cc/trees/layer_tree_host_impl_unittest.cc

Issue 332433003: cc: Remove EnsureRenderSurfaceLayerList, do UpdateDrawProps when needed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ensurersll: . Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl_unittest.cc
diff --git a/cc/trees/layer_tree_host_impl_unittest.cc b/cc/trees/layer_tree_host_impl_unittest.cc
index 45d533b5fb883c173067cdc4d549d793a819fb77..91f98aef8ff21df340b05ab07a209d788038bb9f 100644
--- a/cc/trees/layer_tree_host_impl_unittest.cc
+++ b/cc/trees/layer_tree_host_impl_unittest.cc
@@ -538,7 +538,7 @@ TEST_F(LayerTreeHostImplTest, ScrollWithoutRenderer) {
// We should not crash when trying to scroll after the renderer initialization
// fails.
- EXPECT_EQ(InputHandler::ScrollIgnored,
+ EXPECT_EQ(InputHandler::ScrollStarted,
enne (OOO) 2014/06/11 21:23:07 Can you explain this change more?
danakj 2014/06/11 21:24:38 While we're unable to UpdateDrawProperties, the Sc
enne (OOO) 2014/06/11 21:28:43 Ah, ok. That makes sense. We no longer need a re
Ian Vollick 2014/06/12 15:55:03 Can you please add a 2nd check for a ScrollBegin a
danakj 2014/06/12 16:03:58 An empty RSLL only happens when there is no root l
Ian Vollick 2014/06/12 16:22:19 What I was getting at was hit testing (for scrolli
host_impl_->ScrollBegin(gfx::Point(), InputHandler::Wheel));
}

Powered by Google App Engine
This is Rietveld 408576698