Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 332413005: Add PROJECT to chromium_deps (Closed)

Created:
6 years, 6 months ago by sheyang
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M cdm/codereview.settings View 1 1 chunk +1 line, -0 lines 0 comments Download
A codereview.settings View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/ffmpeg/codereview.settings View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/opus/codereview.settings View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sheyang
6 years, 6 months ago (2014-06-21 00:40:28 UTC) #1
Paweł Hajdan Jr.
This is more tricky, because I'd expect most people to checkout subdirectories of this repo ...
6 years, 6 months ago (2014-06-21 00:41:46 UTC) #2
sheyang
On 2014/06/21 00:41:46, Paweł Hajdan Jr. wrote: > This is more tricky, because I'd expect ...
6 years, 6 months ago (2014-06-21 00:51:47 UTC) #3
sheyang
On 2014/06/21 00:51:47, sheyang wrote: > On 2014/06/21 00:41:46, Paweł Hajdan Jr. wrote: > > ...
6 years, 6 months ago (2014-06-24 21:18:37 UTC) #4
sheyang
Adding ddorwin@ and xhwang@ to reviews changes in cdm/codereview.settings and third_party/ffmpeg/codereview.settings. Adding tlegrand@ to review ...
6 years, 6 months ago (2014-06-25 22:11:22 UTC) #5
xhwang
cdm/codereview.settings and third_party/ffmpeg/codereview.settings lgtm.
6 years, 6 months ago (2014-06-25 22:45:17 UTC) #6
sheyang
Committed patchset #2 manually as r280014 (presubmit successful).
6 years, 6 months ago (2014-06-26 15:51:59 UTC) #7
tlegrand1
On 2014/06/26 15:51:59, sheyang wrote: > Committed patchset #2 manually as r280014 (presubmit successful). What ...
6 years, 5 months ago (2014-06-30 13:04:30 UTC) #8
sheyang
On 2014/06/30 13:04:30, tlegrand1 wrote: > On 2014/06/26 15:51:59, sheyang wrote: > > Committed patchset ...
6 years, 5 months ago (2014-06-30 15:58:49 UTC) #9
tlegrand1
On 2014/06/30 15:58:49, sheyang wrote: > On 2014/06/30 13:04:30, tlegrand1 wrote: > > On 2014/06/26 ...
6 years, 5 months ago (2014-07-01 14:21:41 UTC) #10
ilovebobby906
4 years, 6 months ago (2016-06-22 23:54:38 UTC) #11
Message was sent while issue was closed.
On 2014/06/25 22:11:22, sheyang wrote:
> Adding ddorwin@ and xhwang@ to reviews changes in cdm/codereview.settings and
> third_party/ffmpeg/codereview.settings.
> 
> Adding tlegrand@ to review changes in 	third_party/opus/codereview.settings.
> 
> PTAL. Thanks!

Bob

Powered by Google App Engine
This is Rietveld 408576698