Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 332413004: Generate web, devtools files into their own sub-dirs. (Closed)

Created:
6 years, 6 months ago by c.shu
Modified:
6 years, 6 months ago
CC:
blink-reviews, tzik, apavlov+blink_chromium.org, aandrey+blink_chromium.org, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, falken, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, nhiroki, alecflett+watch_chromium.org, michaeln, serviceworker-reviews, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Generate web, devtools files into their own sub-dirs. BUG=380054 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176762

Patch Set 1 #

Patch Set 2 : more gn build changes #

Patch Set 3 : more gn build changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -56 lines) Patch
M Source/devtools/BUILD.gn View 1 4 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/devtools.gyp View 7 chunks +16 lines, -13 lines 0 comments Download
M Source/modules/BUILD.gn View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/modules.gyp View 3 chunks +12 lines, -12 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/BUILD.gn View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/ColorChooserPopupUIController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/DateTimeChooserImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/web.gyp View 4 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
c.shu
This CL involves some changes in devtools so I include pfeldman as reviewer. Thanks in ...
6 years, 6 months ago (2014-06-20 23:59:51 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-21 02:07:15 UTC) #2
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-21 03:17:28 UTC) #3
c.shu
The CQ bit was unchecked by c.shu@samsung.com
6 years, 6 months ago (2014-06-21 03:17:35 UTC) #4
eseidel
lgtm
6 years, 6 months ago (2014-06-23 16:39:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/332413004/20002
6 years, 6 months ago (2014-06-23 16:39:36 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 16:45:12 UTC) #7
Message was sent while issue was closed. 
Change committed as 176762

Powered by Google App Engine
This is Rietveld 408576698