Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 332413003: Cleanup: Remove #ifdefs in extensions code that is disabled on mobile. (Closed)

Created:
6 years, 6 months ago by Lei Zhang
Modified:
6 years, 6 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove #ifdefs in extensions code that is disabled on mobile. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279038

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -56 lines) Patch
M apps/saved_files_service_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 5 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 5 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 2 3 6 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/guest_view/web_view/web_view_guest.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Lei Zhang
I may have a couple of CLs pending in front of this, but this is ...
6 years, 6 months ago (2014-06-20 19:48:49 UTC) #1
Yoyo Zhou
LGTM
6 years, 6 months ago (2014-06-20 19:51:46 UTC) #2
sxmlarq
On 2014/06/20 19:51:46, Yoyo Zhou wrote: > LGTM Hi
6 years, 6 months ago (2014-06-22 19:53:26 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-22 23:21:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/332413003/40001
6 years, 6 months ago (2014-06-22 23:21:51 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-22 23:39:32 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-22 23:40:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/20187)
6 years, 6 months ago (2014-06-22 23:40:40 UTC) #8
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-23 01:40:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/332413003/60001
6 years, 6 months ago (2014-06-23 01:40:58 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 04:04:16 UTC) #11
Message was sent while issue was closed.
Change committed as 279038

Powered by Google App Engine
This is Rietveld 408576698