Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 332403005: Fix no-op builds, caused by an incorrect output in //sandbox/mac:generate_stubs. (Closed)

Created:
6 years, 6 months ago by Robert Sesek
Modified:
6 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Fix no-op builds, caused by an incorrect output in //sandbox/mac:generate_stubs. BUG=382931 TEST=Build sandbox twice. The second time it says "no work to do". Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sandbox/mac/sandbox_mac.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Robert Sesek
6 years, 6 months ago (2014-06-17 18:23:31 UTC) #1
Mark Mentovai
LGTM
6 years, 6 months ago (2014-06-17 19:25:43 UTC) #2
Robert Sesek
The CQ bit was checked by rsesek@chromium.org
6 years, 6 months ago (2014-06-17 19:28:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/332403005/1
6 years, 6 months ago (2014-06-17 19:30:05 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 10:20:07 UTC) #5
Message was sent while issue was closed.
Change committed as 278013

Powered by Google App Engine
This is Rietveld 408576698