Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 332393003: Manually roll Skia, picking up new SSE4 procs. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
chromium-reviews, reviews_skia.org, henrik.smiding
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Manually roll Skia, picking up new SSE4 procs. https://skia.googlesource.com/skia/+log/12ffdb31c9a01b255768a9a522c7af90a345c952..4a2489f7bbaccfe588597193561526d579004653 CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel BUG= win_chromium_rel failures look flaky NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280859

Patch Set 1 #

Patch Set 2 : roll with SSE4 #

Patch Set 3 : try again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -3 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M skia/BUILD.gn View 1 2 chunks +9 lines, -2 lines 0 comments Download
M skia/skia_library_opts.gyp View 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
mtklein_C
Do we have a procedure for Chrome side roll CLs yet?
6 years, 6 months ago (2014-06-17 15:51:46 UTC) #1
reed1
requires https://codereview.chromium.org/341633002/ to land to fix android dependency bug in remoting/
6 years, 6 months ago (2014-06-17 20:47:50 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-17 20:48:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@chromium.org/332393003/1
6 years, 6 months ago (2014-06-17 20:49:10 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 20:49:11 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-17 20:49:12 UTC) #6
reed1
On 2014/06/17 20:49:12, I haz the power (commit-bot) wrote: > No <span id="abbrex-spnAbbr_92444" class="abbrex-Abbr abbrex-Abbr_LGTM ...
6 years, 6 months ago (2014-06-17 20:55:08 UTC) #7
mtklein
Reviving this CL as a manual roll.
6 years, 5 months ago (2014-06-30 15:21:42 UTC) #8
reed1
lgtm
6 years, 5 months ago (2014-06-30 15:41:40 UTC) #9
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-06-30 15:42:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@chromium.org/332393003/20001
6 years, 5 months ago (2014-06-30 15:43:59 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-06-30 17:17:01 UTC) #12
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 5 months ago (2014-06-30 17:17:47 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 17:17:55 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/44710) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/23261)
6 years, 5 months ago (2014-06-30 17:17:55 UTC) #15
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-01 13:19:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@chromium.org/332393003/40001
6 years, 5 months ago (2014-07-01 13:20:32 UTC) #17
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-01 18:57:02 UTC) #18
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 5 months ago (2014-07-01 19:07:24 UTC) #19
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 5 months ago (2014-07-01 19:07:25 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@chromium.org/332393003/40001
6 years, 5 months ago (2014-07-01 19:09:04 UTC) #21
commit-bot: I haz the power
6 years, 5 months ago (2014-07-01 19:10:43 UTC) #22
Message was sent while issue was closed.
Change committed as 280859

Powered by Google App Engine
This is Rietveld 408576698