Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 332383002: Build content with OS X 10.9 SDK (Closed)

Created:
6 years, 6 months ago by Jiang Jiang
Modified:
6 years, 6 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Build content with OS X 10.9 SDK glFlush() in render_widget_host_view_mac.mm requires gl.h since 10.9 SDK (I suppose it was included implicitly before). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277817

Patch Set 1 #

Patch Set 2 : Need gl.h instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jiang Jiang
6 years, 6 months ago (2014-06-17 09:36:03 UTC) #1
Jiang Jiang
Avi, can you please take a look? Since you are OWNER of content.
6 years, 6 months ago (2014-06-17 09:37:00 UTC) #2
Nico
lgtm
6 years, 6 months ago (2014-06-17 14:53:00 UTC) #3
Avi (use Gerrit)
lgtm
6 years, 6 months ago (2014-06-17 14:57:29 UTC) #4
Jiang Jiang
The CQ bit was checked by jiangj@opera.com
6 years, 6 months ago (2014-06-17 15:25:46 UTC) #5
Jiang Jiang
On 2014/06/17 14:57:29, Avi wrote: > lgtm Thanks both of you!
6 years, 6 months ago (2014-06-17 15:25:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/332383002/20001
6 years, 6 months ago (2014-06-17 15:27:04 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 18:41:07 UTC) #8
Message was sent while issue was closed.
Change committed as 277817

Powered by Google App Engine
This is Rietveld 408576698