Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 332343007: [android_webview] Fix Android.mk module dependencies. (Closed)

Created:
6 years, 5 months ago by mkosiba (inactive)
Modified:
6 years, 5 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

[android_webview] Fix Android.mk module dependencies. LOCAL_ADDITIONAL_DEPENDENCIES works on the file level, not phony target level, so the current rule results in rebuilding the android_webview_java target whenever we run make. BUG=389534 TEST=compile on android_aosp bot NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280319

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M android_webview/Android.mk View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mkosiba (inactive)
6 years, 5 months ago (2014-06-27 12:59:42 UTC) #1
Torne
lgtm
6 years, 5 months ago (2014-06-27 13:01:15 UTC) #2
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 5 months ago (2014-06-27 13:49:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/332343007/1
6 years, 5 months ago (2014-06-27 13:50:55 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-06-27 13:52:00 UTC) #5
Message was sent while issue was closed.
Change committed as 280319

Powered by Google App Engine
This is Rietveld 408576698