Issue 332333004: Revert of [Mac] Reland r276808 Use a native MessagePump instead of a MessagePumpDefault (https://coderevie…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332333004: Revert of [Mac] Reland r276808 Use a native MessagePump instead of a MessagePumpDefault (https://coderevie… (Closed)

Created:
6 years, 6 months ago by ckocagil

Modified:
6 years, 6 months ago

Reviewers:
Mark Mentovai, awong, jeremy

CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul, tonyg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Revert of [Mac] Reland r276808 Use a native MessagePump instead of a MessagePumpDefault (https://coderevie… (https://codereview.chromium.org/331983002/) Reason for revert: Breaks XmppConnectionTest.MultipleConnect on Mac: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/50525 Original issue's description: > Reland change to use a native MessagePump instead of a MessagePumpDefault. > Original CL: https://codereview.chromium.org/331513002/ > > The previous CL caused a bunch of LibJingle unit tests to fail because the tests > were using a gtest death test which runs in the context of a fork()ed but not > execu()ed process. > > A CF Message loop can't live in this environment. Explicitly construct a > MessagePumpDefault for these tests. > > BUG=356804, 385604 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279013 TBR=mark@chromium.org,ajwong@chromium.org,jeremy@chromium.org NOTREECHECKS=true NOTRY=true BUG=356804, 385604 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279019

Created: 6 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -85 lines)			Patch
M	base/message_loop/message_loop.cc	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	base/message_loop/message_pump_default.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	jingle/glue/chrome_async_socket_unittest.cc	View	26 chunks	+39 lines, -48 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions_mac.txt	View	2 chunks	+0 lines, -26 lines	0 comments	Download

Total messages: 1 (0 generated)

ckocagil

6 years, 6 months ago (2014-06-22 20:55:34 UTC) #1

Created Revert of [Mac] Reland r276808 Use a native MessagePump instead of a
MessagePumpDefault (https://coderevie…