Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4098)

Unified Diff: chrome/browser/media/encrypted_media_browsertest.cc

Issue 332323003: Revert of Integrate browser tests with new EME player. (Closed) Base URL: http://git.chromium.org/chromium/src.git@eme_player
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/media/media_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/encrypted_media_browsertest.cc
diff --git a/chrome/browser/media/encrypted_media_browsertest.cc b/chrome/browser/media/encrypted_media_browsertest.cc
index a13de47bb27e3248c5ac9abc8aa41c26786bfc4a..89468aab90fc8765501456068ccdd475365181a0 100644
--- a/chrome/browser/media/encrypted_media_browsertest.cc
+++ b/chrome/browser/media/encrypted_media_browsertest.cc
@@ -64,11 +64,9 @@
const char kUnknownSession[] = "UnknownSession";
// EME-specific test results and errors.
-const char kEmeKeyError[] = "KEY_ERROR";
+const char kEmeKeyError[] = "KEYERROR";
const char kEmeNotSupportedError[] = "NOTSUPPORTEDERROR";
-const char kFileIOTestSuccess[] = "FILE_IO_TEST_SUCCESS";
-
-const char kDefaultEmePlayer[] = "eme_player.html";
+const char kFileIOTestSuccess[] = "FILEIOTESTSUCCESS";
// The type of video src used to load media.
enum SrcType {
@@ -169,7 +167,7 @@
if (!IsPlayBackPossible(key_system))
expected_title = kEmeKeyError;
- RunEncryptedMediaTest(kDefaultEmePlayer,
+ RunEncryptedMediaTest("encrypted_media_player.html",
media_file,
media_type,
key_system,
@@ -182,8 +180,7 @@
bool receivedKeyMessage = false;
EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
browser()->tab_strip_model()->GetActiveWebContents(),
- "window.domAutomationController.send("
- "document.querySelector('video').receivedKeyMessage);",
+ "window.domAutomationController.send(video.receivedKeyMessage);",
&receivedKeyMessage));
EXPECT_TRUE(receivedKeyMessage);
}
@@ -311,7 +308,7 @@
const std::string& expected_title) {
// Since we do not test playback, arbitrarily choose a test file and source
// type.
- RunEncryptedMediaTest(kDefaultEmePlayer,
+ RunEncryptedMediaTest("encrypted_media_player.html",
"bear-a-enc_a.webm",
kWebMAudioOnly,
key_system,
@@ -378,7 +375,7 @@
}
void RunInvalidResponseTest() {
- RunEncryptedMediaTest(kDefaultEmePlayer,
+ RunEncryptedMediaTest("encrypted_media_player.html",
"bear-320x240-av-enc_av.webm",
kWebMAudioVideo,
CurrentKeySystem(),
@@ -594,7 +591,7 @@
#if defined(WIDEVINE_CDM_AVAILABLE)
// The parent key system cannot be used in generateKeyRequest.
IN_PROC_BROWSER_TEST_F(WVEncryptedMediaTest, ParentThrowsException_Prefixed) {
- RunEncryptedMediaTest(kDefaultEmePlayer,
+ RunEncryptedMediaTest("encrypted_media_player.html",
"bear-a-enc_a.webm",
kWebMAudioOnly,
"com.widevine",
@@ -608,7 +605,7 @@
// TODO(jrummell): http://crbug.com/349181
// The parent key system cannot be used when creating MediaKeys.
IN_PROC_BROWSER_TEST_F(WVEncryptedMediaTest, ParentThrowsException) {
- RunEncryptedMediaTest(kDefaultEmePlayer,
+ RunEncryptedMediaTest("encrypted_media_player.html",
"bear-a-enc_a.webm",
kWebMAudioOnly,
"com.widevine",
@@ -625,14 +622,18 @@
TestNonPlaybackCases(kExternalClearKeyInitializeFailKeySystem, kEmeKeyError);
}
+// TODO(jrummell): Fix these tests to handle rejected promises when the CDM
+// crashes. Currently the JavaScript doesn't expect to get any more events
+// after a crash.
+
// When CDM crashes, we should still get a decode error.
-IN_PROC_BROWSER_TEST_F(ECKEncryptedMediaTest, CDMCrashDuringDecode) {
+IN_PROC_BROWSER_TEST_F(ECKEncryptedMediaTest, DISABLED_CDMCrashDuringDecode) {
IgnorePluginCrash();
TestNonPlaybackCases(kExternalClearKeyCrashKeySystem, kError);
}
// Testing that the media browser test does fail on plugin crash.
-IN_PROC_BROWSER_TEST_F(ECKEncryptedMediaTest, CDMExpectedCrash) {
+IN_PROC_BROWSER_TEST_F(ECKEncryptedMediaTest, DISABLED_CDMExpectedCrash) {
// Plugin crash is not ignored by default, the test is expected to fail.
EXPECT_NONFATAL_FAILURE(
TestNonPlaybackCases(kExternalClearKeyCrashKeySystem, kError),
@@ -645,7 +646,7 @@
}
IN_PROC_BROWSER_TEST_F(ECKEncryptedMediaTest, LoadLoadableSession) {
- RunEncryptedMediaTest(kDefaultEmePlayer,
+ RunEncryptedMediaTest("encrypted_media_player.html",
"bear-320x240-v-enc_v.webm",
kWebMVideoOnly,
kExternalClearKeyKeySystem,
@@ -658,7 +659,7 @@
IN_PROC_BROWSER_TEST_F(ECKEncryptedMediaTest, LoadUnknownSession) {
// TODO(xhwang): Add a specific error for this failure, e.g. kSessionNotFound.
- RunEncryptedMediaTest(kDefaultEmePlayer,
+ RunEncryptedMediaTest("encrypted_media_player.html",
"bear-320x240-v-enc_v.webm",
kWebMVideoOnly,
kExternalClearKeyKeySystem,
« no previous file with comments | « no previous file | chrome/browser/media/media_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698