Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 332323003: Revert of Integrate browser tests with new EME player. (Closed)

Created:
6 years, 6 months ago by chrishtr
Modified:
6 years, 6 months ago
Reviewers:
jrummell, xhwang, ddorwin, shadi
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@eme_player
Visibility:
Public.

Description

Revert of Integrate browser tests with new EME player. (https://codereview.chromium.org/308553002/) Reason for revert: Causes browser tests to fail on all waterfalls. TBR=jrummell,ddorwin,shadi NOTRY=true NOTREECHECKS=true Original issue's description: > Integrate browser tests with new EME player. > > This CL makes several changes to the EME player to enable test > specific expectations possible. > > The EME player can be still used as a stand alone player. > > BUG=356892 > TESTS=out/Release/browser_tests --gtest_filter=*EncryptedMedia* > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -393 lines) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 10 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/media/media_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/media/eme_player.html View 2 chunks +11 lines, -37 lines 0 comments Download
M chrome/test/data/media/eme_player_js/app_loader.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/media/eme_player_js/clearkey_player.js View 1 chunk +11 lines, -3 lines 0 comments Download
D chrome/test/data/media/eme_player_js/file_io_test_player.js View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/test/data/media/eme_player_js/globals.js View 2 chunks +5 lines, -17 lines 0 comments Download
M chrome/test/data/media/eme_player_js/media_source_utils.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/media/eme_player_js/player.js View 4 chunks +12 lines, -43 lines 0 comments Download
M chrome/test/data/media/eme_player_js/prefixed_clearkey_player.js View 1 chunk +11 lines, -3 lines 0 comments Download
M chrome/test/data/media/eme_player_js/prefixed_widevine_player.js View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/media/eme_player_js/test_app.js View 2 chunks +11 lines, -24 lines 0 comments Download
M chrome/test/data/media/eme_player_js/test_config.js View 3 chunks +26 lines, -29 lines 0 comments Download
M chrome/test/data/media/eme_player_js/utils.js View 3 chunks +90 lines, -186 lines 0 comments Download
M chrome/test/data/media/eme_player_js/widevine_player.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
chrishtr
Created Revert of Integrate browser tests with new EME player.
6 years, 6 months ago (2014-06-19 17:11:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/332323003/1
6 years, 6 months ago (2014-06-19 17:12:24 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 17:12:24 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-19 17:12:25 UTC) #4
xhwang
On 2014/06/19 17:12:25, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 6 months ago (2014-06-19 17:14:14 UTC) #5
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 6 months ago (2014-06-19 17:14:16 UTC) #6
chrishtr
The CQ bit was unchecked by chrishtr@chromium.org
6 years, 6 months ago (2014-06-19 17:14:55 UTC) #7
chrishtr
What is the temp fix? Just disabling the two tests again? On Thu, Jun 19, ...
6 years, 6 months ago (2014-06-19 17:16:49 UTC) #8
xhwang
On 2014/06/19 17:16:49, chrishtr wrote: > What is the temp fix? Just disabling the two ...
6 years, 6 months ago (2014-06-19 17:19:15 UTC) #9
shadi
6 years, 6 months ago (2014-06-19 17:20:38 UTC) #10
The tests shouldn't have been enabled in that CL. So, yes I am just
disabling those tests.


On Thu, Jun 19, 2014 at 10:16 AM, Chris Harrelson <chrishtr@chromium.org>
wrote:

> What is the temp fix? Just disabling the two tests again?
>
>
> On Thu, Jun 19, 2014 at 10:14 AM, <xhwang@chromium.org> wrote:
>
>> On 2014/06/19 17:12:25, I haz the power (commit-bot) wrote:
>>
>>> No LGTM from a valid reviewer yet. Only full committers are accepted.
>>> Even if an LGTM may have been provided, it was from a non-committer or
>>> a provisional committer, _not_ a full super star committer.
>>> See http://www.chromium.org/getting-involved/become-a-committer
>>> Note that this has nothing to do with OWNERS files.
>>>
>>
>> not lgtm
>>
>> shadi@ will commit a temp fix in a minute.
>>
>> https://codereview.chromium.org/332323003/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698