Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Issue 332323002: Merge 276987 "Web MIDI: MidiManager crashes if a session is ende..." (Closed)

Created:
6 years, 6 months ago by Takashi Toyoshima
Modified:
6 years, 6 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Merge 276987 "Web MIDI: MidiManager crashes if a session is ende..." > Web MIDI: MidiManager crashes if a session is ended while initializing > > If a MidiManagerClient was destructed while an asynchronous MidiManager > initialization performs, the browser process crashes when the > initilization is finished. On EndSession(), MidiManager should remove > the client even from |pending_clients_|. > > Also, this change fixes a problem that CompleteStartSession() may not be > invoked on a MidiManagerClient if its |client_id| is confclicting with > another MidiManagerClient. > > BUG=382522 > TEST=media_unittests --gtest_filter='Midi*' > > Review URL: https://codereview.chromium.org/323323002 TBR=toyoshim@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -11 lines) Patch
M media/midi/midi_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M media/midi/midi_manager.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M media/midi/midi_manager_unittest.cc View 2 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Takashi Toyoshima
6 years, 6 months ago (2014-06-17 02:04:34 UTC) #1
Takashi Toyoshima
6 years, 6 months ago (2014-06-17 02:05:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r277617.

Powered by Google App Engine
This is Rietveld 408576698