google_apis/gcm/engine/connection_factory_impl.cc - Issue 332313003: Add Finch experiment for selectively bypassing proxies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/engine/connection_factory_impl.cc

Issue 332313003: Add Finch experiment for selectively bypassing proxies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2-line change: Add missing ifdef(SPDY_PROXY_AUTH_ORIGIN); previously only compiled on android, but … Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/gcm/engine/connection_factory_impl.cc

diff --git a/google_apis/gcm/engine/connection_factory_impl.cc b/google_apis/gcm/engine/connection_factory_impl.cc

index bc5a745ea6399e20781f3467f3a19a7ea5e98fa2..c2bbbb6e882e20573ca284ae2ba2a8003612d0a9 100644

--- a/google_apis/gcm/engine/connection_factory_impl.cc

+++ b/google_apis/gcm/engine/connection_factory_impl.cc

@@ -280,10 +280,12 @@ void ConnectionFactoryImpl::ConnectImpl() {

recorder_->RecordConnectionInitiated(current_endpoint.host());

int status = network_session_->proxy_service()->ResolveProxy(

current_endpoint,

+ 0,

&proxy_info_,

base::Bind(&ConnectionFactoryImpl::OnProxyResolveDone,

weak_ptr_factory_.GetWeakPtr()),

&pac_request_,

+ NULL,

bound_net_log_);

if (status != net::ERR_IO_PENDING)

OnProxyResolveDone(status);

« chrome/browser/net/network_stats.cc ('K') | « content/browser/resolve_proxy_msg_helper.cc ('k') | jingle/glue/proxy_resolving_client_socket.cc » ('j') | net/base/network_delegate.h » ('J')