content/browser/resolve_proxy_msg_helper.cc - Issue 332313003: Add Finch experiment for selectively bypassing proxies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/resolve_proxy_msg_helper.cc

Issue 332313003: Add Finch experiment for selectively bypassing proxies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: somehow missed a chromeos ResolveProxy invocation Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/pepper/pepper_network_proxy_host.cc ('k') | google_apis/gcm/engine/connection_factory_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/resolve_proxy_msg_helper.cc

diff --git a/content/browser/resolve_proxy_msg_helper.cc b/content/browser/resolve_proxy_msg_helper.cc

index 5f0a6cd52d797159d75fb64990eb012786881ca6..e189f1c83d3bd323dad707c38bad19d42c538f1c 100644

--- a/content/browser/resolve_proxy_msg_helper.cc

+++ b/content/browser/resolve_proxy_msg_helper.cc

@@ -8,6 +8,7 @@

#include "base/bind_helpers.h"

#include "base/compiler_specific.h"

#include "content/common/view_messages.h"

+#include "net/base/load_flags.h"

#include "net/base/net_errors.h"

#include "net/url_request/url_request_context.h"

#include "net/url_request/url_request_context_getter.h"

@@ -91,10 +92,10 @@ void ResolveProxyMsgHelper::StartPendingRequest() {

// Start the request.

int result = proxy_service_->ResolveProxy(

- req.url, &proxy_info_,

+ req.url, net::LOAD_NORMAL, &proxy_info_,

base::Bind(&ResolveProxyMsgHelper::OnResolveProxyCompleted,

base::Unretained(this)),

- &req.pac_req, net::BoundNetLog());

+ &req.pac_req, NULL, net::BoundNetLog());

// Completed synchronously.

if (result != net::ERR_IO_PENDING)