net/url_request/url_request_ftp_job.cc - Issue 332313003: Add Finch experiment for selectively bypassing proxies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_ftp_job.cc

Issue 332313003: Add Finch experiment for selectively bypassing proxies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address mmenke's feedback R2 Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_request_ftp_job.cc

diff --git a/net/url_request/url_request_ftp_job.cc b/net/url_request/url_request_ftp_job.cc

index caba5219a55c007ce172c9f56a497a218e9386b9..09c6f0f7548f7b5bd61842d0b60b2fb389f4ef0f 100644

--- a/net/url_request/url_request_ftp_job.cc

+++ b/net/url_request/url_request_ftp_job.cc

@@ -102,10 +102,12 @@ void URLRequestFtpJob::Start() {

DCHECK_EQ(request_->context()->proxy_service(), proxy_service_);

rv = proxy_service_->ResolveProxy(

request_->url(),

+ request_->load_flags(),

&proxy_info_,

base::Bind(&URLRequestFtpJob::OnResolveProxyComplete,

base::Unretained(this)),

&pac_request_,

+ NULL,

request_->net_log());

if (rv == ERR_IO_PENDING)

« net/proxy/proxy_service_unittest.cc ('K') | « net/socket_stream/socket_stream.cc ('k') | no next file » | no next file with comments »