Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 332253002: Fix the flushing process of DecryptingAudioDecoder. (Closed)

Created:
6 years, 6 months ago by xhwang
Modified:
6 years, 6 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix the flushing process of DecryptingAudioDecoder. This is the audio part of r277270. When Decode(EOS) is called on DecryptingAudioDecoder, the decoder should keep flushing the decryptor with EOS input until NeedMoreData() is returned. Then the decoder can return the DecodeCB. BUG=338529 TEST=Fix unittest to cover this case. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277836

Patch Set 1 #

Patch Set 2 : Returns EOS frame after decoder flushed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -70 lines) Patch
M media/filters/decrypting_audio_decoder.cc View 1 2 chunks +10 lines, -4 lines 0 comments Download
M media/filters/decrypting_audio_decoder_unittest.cc View 1 7 chunks +51 lines, -63 lines 0 comments Download
M media/filters/decrypting_video_decoder.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M media/filters/decrypting_video_decoder_unittest.cc View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
xhwang
This is the audio one. PTAL Note that in the last CL and this one, ...
6 years, 6 months ago (2014-06-16 18:04:58 UTC) #1
Sergey Ulanov
lgtm
6 years, 6 months ago (2014-06-16 23:28:44 UTC) #2
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 6 months ago (2014-06-17 01:53:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/332253002/1
6 years, 6 months ago (2014-06-17 01:55:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 11:52:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/28131)
6 years, 6 months ago (2014-06-17 11:52:09 UTC) #6
xhwang
I added OutputCB(EOS) back after the decoder is flushed. It turned out that there are ...
6 years, 6 months ago (2014-06-17 16:40:54 UTC) #7
Sergey Ulanov
lgtm
6 years, 6 months ago (2014-06-17 17:42:47 UTC) #8
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 6 months ago (2014-06-17 17:48:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/332253002/20001
6 years, 6 months ago (2014-06-17 17:49:13 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 19:21:24 UTC) #11
Message was sent while issue was closed.
Change committed as 277836

Powered by Google App Engine
This is Rietveld 408576698