chrome/browser/chromeos/login/screens/error_screen_actor.h - Issue 332243002: Network connectivity errors handling (incl. CP) for enrollment flow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/screens/error_screen_actor.h

Issue 332243002: Network connectivity errors handling (incl. CP) for enrollment flow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/login/screens/error_screen_actor.h

diff --git a/chrome/browser/chromeos/login/screens/error_screen_actor.h b/chrome/browser/chromeos/login/screens/error_screen_actor.h

index 5dd4e8d6d32a83b1440f05ff3fab74d4d8830c45..d987fe6e0afa877f6eb2034873a74f8fb8d7c61a 100644

--- a/chrome/browser/chromeos/login/screens/error_screen_actor.h

+++ b/chrome/browser/chromeos/login/screens/error_screen_actor.h

@@ -53,6 +53,11 @@ class ErrorScreenActor {

virtual void Show(OobeDisplay::Screen parent_screen,

base::DictionaryValue* params) = 0;

+ // Shows the screen and call |hide_closure| on hide.

ygorshenin1 2014/06/19 18:28:53 nit: I suggest to rename "hide_closure" to "on_hid

Roman Sorokin (ftl) 2014/06/23 12:58:30 Done.

+ virtual void Show(OobeDisplay::Screen parent_screen,

+ base::DictionaryValue* params,

+ const base::Closure& hide_closure) = 0;

// Hides the screen.

virtual void Hide() = 0;

« no previous file with comments | « no previous file | chrome/browser/chromeos/login/screens/mock_error_screen.h » ('j') | chrome/browser/chromeos/login/ui/webui_login_view.h » ('J')