chrome/renderer/resources/extensions/enterprise_platform_keys/subtle_crypto.js - Issue 332233002: enterprise.platformKeys: Copy-on-read the 'algorithm' member of Key objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/enterprise_platform_keys/subtle_crypto.js

Issue 332233002: enterprise.platformKeys: Copy-on-read the 'algorithm' member of Key objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/resources/extensions/enterprise_platform_keys/key.js ('K') | « chrome/renderer/resources/extensions/enterprise_platform_keys/key.js ('k') | chrome/test/data/extensions/api_test/enterprise_platform_keys.crx » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/enterprise_platform_keys/subtle_crypto.js

diff --git a/chrome/renderer/resources/extensions/enterprise_platform_keys/subtle_crypto.js b/chrome/renderer/resources/extensions/enterprise_platform_keys/subtle_crypto.js

index 531d46b70256b7c3b8f94f16c1addc76b9a2048b..017a3e26d7f06a1fa036fcfaa7b5194f54085c19 100644

--- a/chrome/renderer/resources/extensions/enterprise_platform_keys/subtle_crypto.js

+++ b/chrome/renderer/resources/extensions/enterprise_platform_keys/subtle_crypto.js

@@ -102,6 +102,11 @@ SubtleCryptoImpl.prototype.generateKey =

throw CreateSyntaxError();

}

+ // normalizeAlgorithm returns an array, but publicExponent should be a

+ // Uint8Array.

+ normalizedAlgorithmParameters.publicExponent =

+ new Uint8Array(normalizedAlgorithmParameters.publicExponent);

if (normalizedAlgorithmParameters.name !== 'RSASSA-PKCS1-v1_5' ||

!equalsStandardPublicExponent(

normalizedAlgorithmParameters.publicExponent)) {