chrome/renderer/extensions/enterprise_platform_keys_natives.h - Issue 332233002: enterprise.platformKeys: Copy-on-read the 'algorithm' member of Key objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/enterprise_platform_keys_natives.h

Issue 332233002: enterprise.platformKeys: Copy-on-read the 'algorithm' member of Key objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/enterprise_platform_keys/key.js » ('j') | chrome/renderer/resources/extensions/enterprise_platform_keys/key.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/enterprise_platform_keys_natives.h

diff --git a/chrome/renderer/extensions/enterprise_platform_keys_natives.h b/chrome/renderer/extensions/enterprise_platform_keys_natives.h

index 6afd99fcedb373277366a280a03acb91e6158e70..9649aee268d17dfc396b3d6797881d5c3b7453dc 100644

--- a/chrome/renderer/extensions/enterprise_platform_keys_natives.h

+++ b/chrome/renderer/extensions/enterprise_platform_keys_natives.h

@@ -23,7 +23,8 @@ class EnterprisePlatformKeysNatives : public ObjectBackedNativeHandler {

// |operation|: A string describing the operation. Supported operations are

// "GenerateKey", "Sign" and "Verify".

// Returns the normalized dictionary on success, or null if some required

- // parameters are missing or not supported.

+ // parameters are missing or not supported. Note that it returns untyped

+ // arrays instead of typed arrays (e.g. for RSA publicExponent).

void NormalizeAlgorithm(const v8::FunctionCallbackInfo<v8::Value>& call_info);

DISALLOW_COPY_AND_ASSIGN(EnterprisePlatformKeysNatives);