Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7648)

Unified Diff: chrome/renderer/resources/extensions/enterprise_platform_keys/key.js

Issue 332233002: enterprise.platformKeys: Copy-on-read the 'algorithm' member of Key objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed the unnecessary unit test. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/enterprise_platform_keys.crx » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/enterprise_platform_keys/key.js
diff --git a/chrome/renderer/resources/extensions/enterprise_platform_keys/key.js b/chrome/renderer/resources/extensions/enterprise_platform_keys/key.js
index 7d146cc69acc1193153a4b3355984d5eca741bf8..e46bbcb3522ac0eef4c2d5f4903d0308ae415731 100644
--- a/chrome/renderer/resources/extensions/enterprise_platform_keys/key.js
+++ b/chrome/renderer/resources/extensions/enterprise_platform_keys/key.js
@@ -40,10 +40,19 @@ var KeyImpl = function(type, publicKeySpki, algorithm, usages, extractable) {
this.extractable = extractable;
};
-var Key =
- utils.expose('Key',
- KeyImpl,
- {readonly:['extractable', 'type', 'algorithm', 'usages']});
+var KeyBase = function() {};
+
+Object.defineProperty(KeyBase.prototype, 'algorithm', {
+ enumerable: true,
+ get: function() {
+ return utils.deepCopy(privates(this).impl.algorithm);
+ }
+});
+
+var Key = utils.expose(
+ 'Key',
+ KeyImpl,
+ {superclass: KeyBase, readonly: ['extractable', 'type', 'usages']});
/**
* Returns |key|'s Subject Public Key Info. Throws an exception if |key| is not
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/enterprise_platform_keys.crx » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698